Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(discovery): add generated ID to ServiceRefs #1056

Closed
wants to merge 4 commits into from
Closed

feat(discovery): add generated ID to ServiceRefs #1056

wants to merge 4 commits into from

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Aug 23, 2022 •
edited
Loading

Related to #1046
Related to #520
Related to #939
Depends on cryostatio/cryostat-web#501
Depends on #1047

@andrewazores andrewazores added the feat New feature or request label Aug 23, 2022
@andrewazores andrewazores mentioned this pull request Aug 23, 2022
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2022 •
edited
Loading

This PR/issue depends on:

@andrewazores andrewazores marked this pull request as draft August 23, 2022 13:55
@andrewazores
Copy link
Member Author 

[ERROR] Failures:
[ERROR]   CustomTargetsIT.targetShouldAppearInListing:175
Expected: iterable with items [<{"connectUrl":"service:jmx:rmi:///jndi/rmi://cryostat-itests:9091/jmxrmi","annotations":{"cryostat":{"JAVA_MAIN":"io.cryostat.Cryostat","PORT":"9091","HOST":"cryostat-itests","REALM":"JDP"},"platform":{}},"alias":"io.cryostat.Cryostat","labels":{}}>, <{"connectUrl":"localhost:0","annotations":{"cryostat":{"REALM":"Custom Targets"},"platform":{}},"alias":"self","labels":{}}>] in any order
     but: not matched: <{"id":"bb9df24f-74c2-46cc-9da9-68f87e8e8e76","connectUrl":"localhost:0","alias":"self","labels":{},"annotations":{"platform":{},"cryostat":{"REALM":"Custom Targets"}}}>
[ERROR]   CustomTargetsIT.targetShouldNoLongerAppearInListing:264
Expected: iterable containing [<{"connectUrl":"service:jmx:rmi:///jndi/rmi://cryostat-itests:9091/jmxrmi","annotations":{"cryostat":{"JAVA_MAIN":"io.cryostat.Cryostat","PORT":"9091","HOST":"cryostat-itests","REALM":"JDP"},"platform":{}},"alias":"io.cryostat.Cryostat","labels":{}}>]
     but: item 0: was <{"id":"17a2b8a9-e479-473b-a4c4-372bb2d40241","connectUrl":"service:jmx:rmi:///jndi/rmi://cryostat-itests:9091/jmxrmi","alias":"io.cryostat.Cryostat","labels":{},"annotations":{"platform":{},"cryostat":{"HOST":"cryostat-itests","PORT":"9091","JAVA_MAIN":"io.cryostat.Cryostat","REALM":"JDP"}}}>
[INFO]
[ERROR] Tests run: 143, Failures: 2, Errors: 0, Skipped: 1

CustomTargetsIT just needs updating to expect a random UUID ID in those responses.

@andrewazores andrewazores force-pushed the serviceref-id branch 2 times, most recently from 3496136 to 7d0a294 Compare August 23, 2022 19:02
@andrewazores andrewazores mentioned this pull request Aug 25, 2022
Closed
@andrewazores andrewazores force-pushed the serviceref-id branch 2 times, most recently from 4a1a30f to a7e45a6 Compare September 15, 2022 14:37
@andrewazores andrewazores mentioned this pull request Sep 30, 2022
Closed
@andrewazores
Copy link
Member Author

Obsolete, replaced by #1089

@andrewazores andrewazores deleted the serviceref-id branch November 3, 2022 18:40
@mergify mergify bot added the safe-to-test label Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependent feat New feature or request safe-to-test
Projects
No open projects
2.3.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andrewazores